Refactor ObsADT::Change georef to include only QCed observations#79
Open
jspsl wants to merge 5 commits into
Open
Refactor ObsADT::Change georef to include only QCed observations#79jspsl wants to merge 5 commits into
jspsl wants to merge 5 commits into
Conversation
Modify the way the reference ADT is calculated to include only the observations that passed the QC steps defined in the IODA yaml. This avoids contaminating the ADT that is assimilate with any wrog data that is filtered out in the QC.
* change superrefraction flag * change qcflag to 30 which represents superrefraction * Testing CI * trigger CI --------- Co-authored-by: rajichidamb <rchidamb@ucar.edu> Co-authored-by: Francois Hebert <hebert@ucar.edu> Co-authored-by: BenjaminRuston <benr@ucar.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modify the way the reference ADT is calculated to include only the observations that passed the QC steps defined in the IODA yaml.
This avoids contaminating the ADT that is assimilate with any wrog data that is filtered out in the QC.
Description
Included the "qc_flags" variable and used it to filter the data prior to calculating the reference water level.
Impact
No impact expected
Checklist